Incorrect choice of graphics for stretch mode

john26

I thought I'd start a new thread on this as I now think it may be a bug. And it's quite serious as it means many Gideros apps running on Android will chose the wrong graphics set for the most popular Android devices.

My game has logical dimensions 320x480 and @2x graphics as well as base. I am testing on resolution 480x854 in the simulator using stretch mode. That's a scaling of 1.5 in the x-direction and 1.779 in the y-direction. Now in stretch mode, According to @atilim, Gideros should take the average scaling which is (1.5+1.779)/2=1.6395. Since this is (much) closer to 2 than it is to 1, it should chose the @2x graphics. However, it chooses the base graphics instead.

This is serious as most Android devices have a resolution roughly as mentioned above so many users will get a sub optimal experience.

john26

Any thoughts...? :-)

ar2rsawseen

Hello @john26 I have tried the settings you specified and they seem to work as expected, the @2x image is used. Even with 480x800 resolution

I've attached the screenshots:

john26

Thanks for looking into this. I will try again and see if I have made a mistake. I am running a slightly older version v2012.9.10, where any changes made recently?

I will post some screenshots as well to show you what I'm getting.

ar2rsawseen

@john26 I think that autoscaling code was not modified for a long time, so your version should also work correctly.

Check if you provided Logical dimensions in correct order

john26

I found the source of the problem. I have base and @2x for all graphics but also a small number of @1.5x for some graphics. Gideros calculated a ratio of 1.6395 for 480x854 so tried to load the @1.5x but couldn't find them for most bitmaps so reverted to base. It would be better if it reverted to @2x since this is closer than base.

I solved the problem by simply removing the @1.5x graphics.

So my fault but better if Gideros finds the *best* graphic with no special preference for base, IMO.

ar2rsawseen

@john26 yes you are right, for efficiency, the suffix to be used is only checked for the first image, so if you don't have it, it will revert to base and use the base on all other images

It would be inefficient to recheck every image every time, but as @atilim commented somewhere on the other thread, it will be fixed and will take closest possible and not base image