no keycode sent for some keys when shift is being pressed

keszegh

i wanted to assign an event to ctrl+shift+tab, but when ctrl and shift are both pressed then tab sends a keycode 0 instead of 9. i've noticed that shift is causing the trouble, that is, when shift is pressed then pressing some other keys does not send the right keycode. in particular shift+tab and shift+` do not work, but there may be other keys too with this issue.

oleg

http://forum.giderosmobile.com/discussion/comment/56726/#Comment_56726

keszegh

thanks @oleg, good tip, it indeed fires does fire a meaningful realCode, so i can use it as a workaround.

i still think it is a bug that having shift pressed some keys do not fire proper keyCode and i even find it unintuitive that the same keys fire a different realCode when shift is pressed.

hgy29

The is all platform dependent behavior I am afraid. Basically gideros gets a realCode from the platform and tries to map it to its own set of keyCodes. Why the specific combination you pressed doesn’t produce the same realCode on QT is a mystery. here is gideros mapping table for Qt: https://github.com/gideros/gideros/blob/0dbdafce8d1ed054422831b7099e7a7e752257b1/libgid/src/qt/ginput-qt.cpp#L21
QT codes are: http://www.qt-project.org/doc/qt-4.8/qt.html#Key-enum

What is needed is adding more entries to map the real code QT sends for Carl+Shift+Tab to keyCode for Tab...

rrraptor

hgy29 said:

What is needed is adding more entries to map the real code QT sends for Carl+Shift+Tab to keyCode for Tab...

So, I wrote a little parser and generated some missing keys.

hgy29

rrraptor said:

So, I wrote a little parser and generated some missing keys.

What is the value associated with each key ? They don't look like Gideros key codes.

rrraptor

hgy29 said:

rrraptor said:

So, I wrote a little parser and generated some missing keys.

What is the value associated with each key ? They don't look like Gideros key codes.

Well, they are from qt
So, it must be this values or its combinations?
https://github.com/gideros/gideros/blob/5791caa194d7792b35fb4073e3a7b0124d8bcb57/libgid/include/ginput.h

GINPUT_KEY_1 = 0x31

In qt its
Qt::Key_1 which is 0x31 aswell

https://doc.qt.io/archives/qt-4.8/qt.html#Key-enum

rrraptor

stage:addEventListener("keyDown", function(e) print(("0x%x"):format(e.realCode)) end)

If I will press SHIFT+4 I will get 0x24 which is Qt::Key_Dollar, so we need another enum for gideros? Like KeyCode.DOLLAR ?

Modified version

hgy29

GINPUT_xxx constants are platform independent, the key map is supposed to convert QT specific keycodes to gideros equivalent (if it exists). I think the issue @keszegh had is that QT don't send the same key code (I really mean key, not char) if shift is pressed too. I noticed that some key codes have a '1' bit set in upper bits, maybe we should just mask it off, or something like that. We could also pass the QT key code to Gideros for non mapped keys as a catch-all measure.

keszegh

That's my problem indeed.

rrraptor

hgy29 said:

GINPUT_xxx constants are platform independent, the key map is supposed to convert QT specific keycodes to gideros equivalent (if it exists).

Ah, I see now

So we need to know exact code for a key (on each platform) in order to add it to gideros? Does not seems to be realy hard Just need a WM and Google to find out which one is which.

My point is that we need more options to KeyCode.
This keys dont have their keyCodes in gideros:

Thats a "few" Idk what we are missing on Mac, but its something like F13-F19, "option" and "command".

hgy29

Yes, I agree, the whole keyboard should be supported. Tab is supported already BTW. The trouble is how to name them, since keyboards layout are different depending on the country. F1-F12 keys are easy, as well as the num pad and other 'control' keys, but symbol keys are more difficult. US keyboard should be the reference I think.

rrraptor

hgy29 said:

Tab is supported already BTW.

Not fully. If you hold shift and press tab, gideros does not recognize it. Its called Backtab in QT and its code - 0x01000002, for normal TAB - 0x01000001

hgy29

Yes, that's the OP issue. But modifiers shouldn't change the key code, so we must map QT's backtab to Gideros TAB key. I'll add that mapping to fix @keszegh issue

keszegh

sorry to resurrect an old thread.
i noticed that SHIFT+",/<" key has different realCode compared to ",/<" key, the same goes for the "./>" key.
reading back the last few messages, should it be the case that SHIFT does not modify the realCode or keyCode? or only for the keyCode? (the keyCodes are 0's always for these keys)

hgy29

Well "real code" is the platform dependant key code, it isn't (shouldn't) be modified by gideros, so I guess the system itself sends a different code when shift is pressed for those keys

keszegh

i see, thanks.
so perhaps what i wish for is keyCodes for these two keys (And any other key on a normal keyboard that does not have a keyCode yet).
in any case it is easy to workaround, just i needed a few minutes to realize why my initial code does not work (especially that with ctrl+<> and alt+<> i did not have such an issue).

keszegh

another issue (probably needs to be corrected only in docs):
KeyCode.PAGEDOWN and KeyCode.PAGEUP do not exist
but KeyCode.PAGE_DOWN and KeyCode.PAGE_UP seem to do exist.