ImGui new thread

SinisterSoft

@hgy29 did you get the imgui improvements before the build?

MoKaLux

post edited/deleted

in p_open what does p mean? panel?

do you validate this page? https://wiki.gideros.rocks/index.php/ImGui.Core:beginWindow

PLEASE DON'T CHANGE IMGUI TOO MUCH PLEASE

hgy29

SinisterSoft said:

@hgy29 did you get the imgui improvements before the build?

Yes, build started just now with up to date github sources

rrraptor

MoKaLux said:

in p_open what does p mean? panel?

parameter e.g. argument?

In godot source code it is used all the time

MoKaLux said:

do you validate this page? https://wiki.gideros.rocks/index.php/ImGui.Core:beginWindow

Seems good. But why all functions called "ImGui.Core.XXX"?

SinisterSoft

@rrraptor

Looks good. I've noticed a couple of things:

If you set the width to -1 it takes the full size (that is to be expected and looks good) that it can fit in, but if you set the width to 0 then it sets it to the size of the text (but doesn't take into account any type of margin or the image in the button. I'm guessing the same applies to height.

SinisterSoft

I managed to get it to fit in with my existing table structure really nicely...

if b then local size=48 local w=ui:getWindowContentRegionWidth() if not s.stackedButtons then size=20 w=((w+spX)/#b)-spX end ui:pushStyleVar(ImGui.StyleVar_ButtonTextAlign,0,0.5) for loop=1,#b do if ui:scaledImageButtonWithText(b[loop,5],b[loop,2],size,size,w,size) then callButton=loop end if not s.stackedButtons then ui:sameLine() end end ui:popStyleVar() end

SinisterSoft

@rrraptor Has something changed with drawlList:addImage ? It used to position just right, but now seems a little off...

drawList:addImage(s.icon,x+x2,y+x2,x+x2+h2,y+x2+h2)

Edit:

This seems to have fixed it:

local style=ui:getStyle() local spX,spY=style:getItemSpacing() local h2=(h*0.9) local x2=(h-h2)/2 drawList:pushClipRect(x,y,x+w,y+h) drawList:addRectFilledMultiColor(x,y,x+w,y+h,c2,1,c1,1,c1,1,c2,1) drawList:addImage(s.icon,spY+x+x2,spY+y+x2,spY+x+x2+h2,spY+y+x2+h2)

keszegh

@SinisterSoft , nice, imGui disguised completely. if it's not that complicated, it would be nice to make a simple example included in gideros that makes such a menu system (extracted from your code).

SinisterSoft

Yes, I'll get something together once it's done (for the examples).

MoKaLux

rrraptor said:

But why all functions called "ImGui.Core.XXX"?

I had to put it in its own subclass for the wiki navigation.

MoKaLux

deleted ImGui is getting tough
I don't understand checkboxFlags

require "ImGui"   local imgui = ImGui.new() stage:addChild(imgui) local cb01 = true local cbf01 = 1   function onEnterFrame(e) imgui:newFrame(e) cb01 = imgui:checkbox("checkbox 01", cb01) --flags, isChanged = ImGui:checkboxFlags(label, [flags = 0, falgs_value = 0]) cbf01, cbf01c = imgui:checkboxFlags("checkbox 01", cbf01, 4) if cbf01c then print(cbf01) end -- prints 4 when checkbox is checked imgui:endFrame() imgui:render() end stage:addEventListener(Event.ENTER_FRAME, onEnterFrame)

Why can't we store strings, only ints?

SinisterSoft

@rrraptor I think there is an error with the html5 export.

Sometimes when I call imgui:render() I get an error:
bad argument #3 to '?' (number expected, got string)

This doesn't happen on the Windows player.

What happens just before though is interesting, maybe it happens on Windows too, but not enough to crash it?



This is the test app: https://web.reportcomplete.com/

Here is a link to the unencrypted GApp so you can try it out:
https://web.reportcomplete.com/ReportComplete.GApp.gidz

If you export a project to HTML5, then replace the GApp.gidz file with that one, you should be able to test any HTML5 code modifications to your plugin.

(I'm using the test build of Gideros, so I have your latest version submitted to github)

rrraptor

SinisterSoft said:

Sometimes when I call imgui:render() I get an error:
bad argument #3 to '?' (number expected, got string)

But there is no arguments to "render" function.
https://github.com/gideros/gideros/blob/5d5a4ac04c83b0c61441b9d8d6c357407a41a355/plugins/imgui/source/Common/imgui_bindings.cpp#L1750
Must be something else...
Probably something wrong with LUA stack? @hgy29 do I need to make sure that the stack is empty when any function is called?

SinisterSoft said:

Here is a link to the unencrypted GApp so you can try it out:
https://web.reportcomplete.com/ReportComplete.GApp.gidz

If you export a project to HTML5, then replace the GApp.gidz file with that one, you should be able to test any HTML5 code modifications to your plugin.

Im only getting this files. There is no *.gidz file.

rrraptor

MoKaLux said:

I don't understand checkboxFlags

Me too.

And the code for that:
https://github.com/MultiPain/Gideros_examples/blob/639321e56cf7039ef3a31547261f3ee0138316d0/ImGuiTablesDemo/assets/TablesDemo.lua#L371

SinisterSoft

You need to tick 'compression' to on.

MoKaLux

filledSliderFloat2 seems to be broken?
filledSliderFloat and filledSliderFloat3 work fine.

require "ImGui"   local imgui = ImGui.new() stage:addChild(imgui)   local window01 = true local value = 20 local value01 = 50 local value02 = 30 local value03 = 10   function onEnterFrame(e) imgui:newFrame(e) window01 = imgui:beginWindow("Window 01") if window01 then imgui:text("Hello Dear ImGui!") local isChanged = false value, isChanged = imgui:filledSliderFloat("slider f", true, value, 0, 100, "%.2f", 0) if isChanged then print(value) end -- value01, value02, isChanged = imgui:filledSliderFloat2("slider2", true, value01, value02, 0, 100, "%.1f", 0) -- if isChanged then print(value01, value02) end value01, value02, value03, isChanged = imgui:filledSliderFloat3("slider3", true, value01, value02, value03, 0, 100, "%.1f", 0) if isChanged then print(value01, value02, value03) end end imgui:endFrame() imgui:render() end   stage:addEventListener(Event.ENTER_FRAME, onEnterFrame)

rrraptor

MoKaLux said:

filledSliderFloat2 seems to be broken?

Yeap
https://github.com/gideros/gideros/blob/7aba140cb3ccfc92c8df451f4e3a48c585556af5/plugins/imgui/source/Common/imgui_bindings.cpp#L3462

MoKaLux

should also be return 3?
EDIT: also:
float v_min = luaL_checknumber(L, 6, 0);
float v_max = luaL_checknumber(L, 7, 0);

https://github.com/gideros/gideros/blob/7aba140cb3ccfc92c8df451f4e3a48c585556af5/plugins/imgui/source/Common/imgui_bindings.cpp#L3467

rrraptor

MoKaLux said:

should also be return 3?
EDIT: also:
float v_min = luaL_checknumber(L, 6, 0);
float v_max = luaL_checknumber(L, 7, 0);

https://github.com/gideros/gideros/blob/7aba140cb3ccfc92c8df451f4e3a48c585556af5/plugins/imgui/source/Common/imgui_bindings.cpp#L3467

Yeah, that is my copy-paste mistakes

SinisterSoft

@rrraptor Did you manage to spot what was causing the Lua stack issue?

MoKaLux

https://github.com/gideros/gideros/pull/508
hopefully I didn't mess things up
EDIT: I put 0 instead of 0.0f at some places patch-2
I messed up, starting again
https://github.com/gideros/gideros/pull/509/commits/16fe99198125dedfae6ff94b4de830814ba185d9

Can I also change this for consistency?

int InputTextWithHint(lua_State* L) { const char* label = luaL_checkstring(L, 2); const char* text = luaL_checkstring(L, 3); const char* hint = luaL_checkstring(L, 4); size_t buf_size = luaL_checkinteger(L, 5); char* buffer = new char[buf_size]; sprintf(buffer, "%s", text); ImGuiInputTextFlags flags = luaL_optinteger(L, 6, 0);   bool result = ImGui::InputTextWithHint(label, hint, buffer, buf_size, flags); lua_pushstring(L, &(*buffer)); lua_pushboolean(L, result); delete[] buffer; return 2; }

to this:

int InputTextWithHint(lua_State* L) { const char* label = luaL_checkstring(L, 2); const char* text = luaL_checkstring(L, 3); const char* hint = luaL_checkstring(L, 4); // size_t buf_size = luaL_checkinteger(L, 5); int buffer_size = luaL_checkinteger(L, 5); char* buffer = new char[buffer_size]; sprintf(buffer, "%s", text); ImGuiInputTextFlags flags = luaL_optinteger(L, 6, 0);   // bool result = ImGui::InputTextWithHint(label, hint, buffer, buf_size, flags); bool result = ImGui::InputTextWithHint(label, hint, buffer, buffer_size, flags); lua_pushstring(L, &(*buffer)); lua_pushboolean(L, result); delete[] buffer; return 2; }

MoKaLux

Color button seems to be broken but I don't know how to handle this one FIXED IN GIDEROS 2021.3

int ColorButton(lua_State* L) { const char* desc_id = luaL_checkstring(L, 2); ImVec4 col = GColor::toVec4(luaL_checkinteger(L, 3), luaL_optnumber(L, 4, 1.0f)); ImVec2 size = ImVec2(luaL_optnumber(L, 5, 0), luaL_optnumber(L, 6, 0)); ImGuiColorEditFlags flags = luaL_optinteger(L, 7, 0);   lua_pushboolean(L, ImGui::ColorButton(desc_id, col, flags, size)); return 1; }

https://github.com/gideros/gideros/blob/7aba140cb3ccfc92c8df451f4e3a48c585556af5/plugins/imgui/source/Common/imgui_bindings.cpp#L3993

The color button is supposed to return true only when pressed but right now it always returns true. A sample code:

Dear ImGui is AMAZING

rrraptor

MoKaLux said:

Color button seems to be broken but I don't know how to handle this one

2021.3

MoKaLux

cool I am still using 2021.2 will download the new one now DONE thank you rrraptor.
I will need to revisit the wiki for a couple of updated imgui widgets that I missed .

Very impressive job rrraptor
Dear ImGui rocks

SinisterSoft

@MoKaLux Can you see if there is a stack issue with one of the calls whilst tinkering? Or did you spot it already?

MoKaLux

SinisterSoft, I am testing most of the widgets so I can also add them as examples in the wiki. I have made a pull request where a couple of callbacks were strange, example:

int DragInt2(lua_State* L)
bool result = ImGui::DragInt(label, vec2i, v_speed, v_min, v_max, format, sliderFlag);
bool result = ImGui::DragInt2(label, vec2i, v_speed, v_min, v_max, format, sliderFlag);

I am waiting for the commit confirmation before I continue so I know that what I am doing is legit.

MoKaLux

hope you are all doing fine
I would like to test the changes I make to imgui_bindings.cpp (https://github.com/gideros/gideros/blob/master/plugins/imgui/source/Common/imgui_bindings.cpp)
and maybe some other files too(?), the question is how can I compile this?
I think I need to recompile the imgui plugin with the changes to create a .dll file? I think I also need either Visual Studio (please no!) or Qt (I prefer Qt but which version)?

Can somebody tell me the steps please?

PS: there is this thread https://forum.gideros.rocks/discussion/comment/61324/#Comment_61324 will try

rrraptor

MoKaLux said:

hope you are all doing fine
I would like to test the changes I make to imgui_bindings.cpp (https://github.com/gideros/gideros/blob/master/plugins/imgui/source/Common/imgui_bindings.cpp)
and maybe some other files too(?), the question is how can I compile this?
I think I need to recompile the imgui plugin with the changes to create a .dll file? I think I also need either Visual Studio (please no!) or Qt (I prefer Qt but which version)?

Can somebody tell me the steps please?

PS: there is this thread https://forum.gideros.rocks/discussion/comment/61324/#Comment_61324 will try

Plugin code

There is a macro:

It defines if the build is in "beta". That means, that it includes DOCKING stuff, node editor extension, and the plugin name is different (plugin name is used by require function from LUA).
You can redefine the name here:

A quick intro to QT

Im using QT creator 4.12.4, but it does not really matter (you can use 5.x version). All you have to do is to install qt and open project file (*.pro).

1 - project tree
2 - dll name
3 - all your source code files
4 - all your header files
As you can see I have some extra files included from gideros sources, the path is relative to your projects directory. In my case it is: gideros_installation_folder\All Plugins\Gideros_ImGui
You can add extra window tabs (or whatever they called) by using icons:

1 - adds new "window"
2 - closes this "window"

Building

1 - build path
2 - custom steps to automatically copy dll file to gideros "plugins" folder and in my case to project directory aswell (to upload to git). You can add a single step.

1 - path to dll
2 - path to destination folder
Once you are done with all the code, press CLTR+B and wait. In lower right corner you can see the progress.

If everything is OK, then you will get a green line
If not, check the "issues" tab:

rrraptor

1 more thing. When installing QT dont forget to install MinGW compiler.
There should be an option like this one:

MoKaLux

thank you rrraptor, ok for now I have installed Qt 5.10.1 and a couple of tools from the wiki page https://wiki.gideros.rocks/index.php/Compiling_Gideros_Source

and reading your answer made me smile:
Im using QT creator 4.12.4, but it does not really matter (you can use 5.x version). All you have to do is to install qt and open project file (*.pro).

Now I will follow the steps you provided and hopefully build that .dll