ImGui new thread

rrraptor

keszegh said:

btw math.clamp is undocumented in gideros wiki. @MoKaLux i know you are the best to mention this to.

It comes from LUAU:
https://developer.roblox.com/en-us/api-reference/lua-docs

keszegh

so far i did not encounter other issues/anomalies. now it would be nice to have a gideros release with new imgui build, to be able to export to mac as well (and have a smaller windows dll). ty

rrraptor

Ok, created a pull request

rrraptor

keszegh

hi, your workaround to position the triangles in the right corner also is a bit strange, on screenshot you can see that not all triangles are the same size/position.


or is it just a rounding issue? still seems strange.

edit:
it happens e.g. when gui.imgui:setScale(1.2) is set, also bad at 1.25, 1.75, but indeed it is good when scaling is 1 or 2.

keszegh

if this is due to rounding, is there any way to set a value so that all triangles end up to be the same size?
e.g. at scaling 1.25 and triangle size 4 one would expect all triangles to have size 5. yet some of them have size 6.

i came up with this workaround, which looks a bit wasteful but at least works:

function ImGui:showRightClickableSign() local draw_list = self:getWindowDrawList() local x0, y0 = self:getItemRectMin() local x1, y1 = self:getItemRectMax()   local cx0 = draw_list:getClipRectMin() local cx1 = draw_list:getClipRectMax() --x0 = math.clamp(x0, cx0, cx1) x1 = math.clamp(x1, cx0, cx1)   local function sRound(x) return math.round(x*imgui_scaling)/imgui_scaling end   local offset = sRound(1) local size = sRound(3 + offset)   draw_list:addTriangleFilled(sRound(x1)-offset,sRound(y0)+offset,sRound(x1)-size,sRound(y0)+offset,sRound(x1)-offset,sRound(y0)+size, 0xe5e5e5) end

keszegh

btw even with my latest version, although triangles are not getting bigger/smaller randomly, but just like without the clamping trick, in a long scrolling file browser the last item has usually a bigger triangle than the first one.

keszegh

about my original issue with these triangles, it seems that they are drawn at the right place but for some reason some of their parts are not always visible. would it be possible to draw these triangles higher in the drawing order and then maybe they would be completely visible?

edit: perhaps with this in mind you could spotthe bug in the imgui source code?

(and sorry for spamming this topic with this issue, but would be great to resolve it properly)

rrraptor

@keszegh they added a fix
https://github.com/ocornut/imgui/issues/5346
https://github.com/rokups/imgui/commit/6b4cad147c20f352e7e4c89c2173142e07d71ab0
Ill check it later

keszegh

rrraptor said:

@keszegh they added a fix
https://github.com/ocornut/imgui/issues/5346
https://github.com/rokups/imgui/commit/6b4cad147c20f352e7e4c89c2173142e07d71ab0
Ill check it later

thanks for adding that issue at their github, i will be happy to try the fix, let me know.

keszegh

it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

keszegh

i have the following crash report when i do something:
[6636] ../Common/imgui_src/imgui.cpp: (g.WithinEndChild) && "Must call EndChild() and not End()!"

previously it worked fine, maybe i've changed something but as far as i remember i did not. can you check if it is somehow due to imgui code? ty

EDIT: i'm pretty sure that this is an error in my own code, so never mind.

keszegh

keszegh said:

it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

this one remains actual though.

keszegh

keszegh said:

keszegh said:

it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

this one remains actual though.

@rrraptor , any idea?