ImGui new thread

rrraptor · May 25

keszegh said:
btw math.clamp is undocumented in gideros wiki. @MoKaLux i know you are the best to mention this to.

It comes from LUAU:
https://developer.roblox.com/en-us/api-reference/lua-docs

keszegh · May 26

so far i did not encounter other issues/anomalies. now it would be nice to have a gideros release with new imgui build, to be able to export to mac as well (and have a smaller windows dll). ty

rrraptor · May 27

Ok, created a pull request

rrraptor · June 14

keszegh · June 14

hi, your workaround to position the triangles in the right corner also is a bit strange, on screenshot you can see that not all triangles are the same size/position.

or is it just a rounding issue? still seems strange.

edit:
it happens e.g. when gui.imgui:setScale(1.2) is set, also bad at 1.25, 1.75, but indeed it is good when scaling is 1 or 2.

keszegh · June 14

if this is due to rounding, is there any way to set a value so that all triangles end up to be the same size?
e.g. at scaling 1.25 and triangle size 4 one would expect all triangles to have size 5. yet some of them have size 6.

i came up with this workaround, which looks a bit wasteful but at least works:

function ImGui:showRightClickableSign()  
  local draw_list = self:getWindowDrawList()
  local x0, y0 = self:getItemRectMin()
  local x1, y1 = self:getItemRectMax()
 
  local cx0 = draw_list:getClipRectMin()
  local cx1 = draw_list:getClipRectMax()
  --x0 = math.clamp(x0, cx0, cx1)
  x1 = math.clamp(x1, cx0, cx1)    
 
  local function sRound(x)
    return math.round(x*imgui_scaling)/imgui_scaling
  end
 
  local offset = sRound(1)
  local size = sRound(3 + offset)
 
  draw_list:addTriangleFilled(sRound(x1)-offset,sRound(y0)+offset,sRound(x1)-size,sRound(y0)+offset,sRound(x1)-offset,sRound(y0)+size, 0xe5e5e5) 
end

keszegh · June 14

btw even with my latest version, although triangles are not getting bigger/smaller randomly, but just like without the clamping trick, in a long scrolling file browser the last item has usually a bigger triangle than the first one.

keszegh · June 14

about my original issue with these triangles, it seems that they are drawn at the right place but for some reason some of their parts are not always visible. would it be possible to draw these triangles higher in the drawing order and then maybe they would be completely visible?

edit: perhaps with this in mind you could spotthe bug in the imgui source code?

(and sorry for spamming this topic with this issue, but would be great to resolve it properly)

rrraptor · June 15

@keszegh they added a fix
https://github.com/ocornut/imgui/issues/5346
https://github.com/rokups/imgui/commit/6b4cad147c20f352e7e4c89c2173142e07d71ab0
Ill check it later

keszegh · June 15

rrraptor said:
@keszegh they added a fix
https://github.com/ocornut/imgui/issues/5346
https://github.com/rokups/imgui/commit/6b4cad147c20f352e7e4c89c2173142e07d71ab0
Ill check it later

thanks for adding that issue at their github, i will be happy to try the fix, let me know.

keszegh · June 22

it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

keszegh · June 22

i have the following crash report when i do something:
[6636] ../Common/imgui_src/imgui.cpp: (g.WithinEndChild) && "Must call EndChild() and not End()!"

previously it worked fine, maybe i've changed something but as far as i remember i did not. can you check if it is somehow due to imgui code? ty

EDIT: i'm pretty sure that this is an error in my own code, so never mind.

keszegh · June 22

keszegh said:
it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

this one remains actual though.

keszegh · June 24

keszegh said:

keszegh said:
it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.
this one remains actual though.

@rrraptor , any idea?

rrraptor · June 28

@keszegh here is the fixed version:

Yes it jitters a bit when I scale the ui using "ImGui:setScale()", but I dont think I can do anything about that. The only thing I can suggest is to set scale back to 1, and scale the font instead. Or why do you have to scale it to 1.2 or something else?

keszegh said:
i have the following crash report when i do something:
[6636] ../Common/imgui_src/imgui.cpp: (g.WithinEndChild) && "Must call EndChild() and not End()!"

previously it worked fine, maybe i've changed something but as far as i remember i did not. can you check if it is somehow due to imgui code? ty

EDIT: i'm pretty sure that this is an error in my own code, so never mind.

Well, it tells you to use "ImGui:endChild()" instead of "ImGui:endWindow()", maybe messed up some calls?

keszegh said:
it seems that in the colorEdit3 editor the 'original' color is in fact white and not the original color.

No problems for me, maybe you can record a gif aswell (Im using LiceCAP)?

keszegh · June 28

@rrraptor , thanks.
1. for scaling, i need to allow the user to adjust the gui size if the dpi is too small/large.
i will test the fixed dll and waiting for next gideros version to have it too.
2. yes, it was an error in my code, endChild() was hidden in a conditional part which was not always called.
3. the color picker is also my fault, i called
colorlist[i]=imgui:colorPicker4("",colorlist[i], 1, ImGui.ColorEditFlags_NoAlpha, self.originalColor)
but forgot to set the value of self.originalcolor first. (probably it was there earlier but i deleted the code at some point accidentally).

keszegh · June 28

i tried current imgui_beta.dll but the simple code to position my triangles using getItemRectMax() still does not work.

rrraptor · June 29

keszegh said:
i tried current imgui_beta.dll but the simple code to position my triangles using getItemRectMax() still does not work.

dll has not been updated yet. I still have some problems with fonts loading, but I cant tell whether this is my fault or not...

keszegh · June 29

rrraptor said:

keszegh said:
i tried current imgui_beta.dll but the simple code to position my triangles using getItemRectMax() still does not work.
dll has not been updated yet. I still have some problems with fonts loading, but I cant tell whether this is my fault or not...

i see, let me know when i can test. good luck with those fonts.

rrraptor · June 29

keszegh said:

rrraptor said:

keszegh said:
i tried current imgui_beta.dll but the simple code to position my triangles using getItemRectMax() still does not work.
dll has not been updated yet. I still have some problems with fonts loading, but I cant tell whether this is my fault or not...
i see, let me know when i can test. good luck with those fonts.

Updated to 1.88, dll updated.
Changed "require" function to

require "ImGui_beta"

keszegh · June 29

thanks @rrraptor , seems to work well.

keszegh · July 16

@rrraptor , what does this mean?:
"Exposed scalar versions of sliders/drags/number inputs into lua"

rrraptor · July 17

You can have as many drags/slider/number inputs as you want in one row (vec is a vector object from LUAu).

LUA code looks ugly

But there is one more variant:

local tableVars = {0, 0, 0, 0, 0, 0}
ui:dragFloatT("Table", tableVars)

keszegh · July 19

[post deleted, found the issue in my code]

rrraptor · July 21

Playing around with nodes editor

MoKaLux · July 21

this looks awesome, well done rrraptor

keszegh · July 31

i've a table of selectables and i want to add a multiselect feature, i.e. pressing the mouse button on one of them and dragging the mouse should select a range of them. to implement this i thought to use isItemActive and isItemHovered for these selectables. is that not possible? (it seems so)
in this case do i need to add invisible buttons over the selectables to make this work?
ty

rrraptor · August 8

keszegh said:
i've a table of selectables and i want to add a multiselect feature, i.e. pressing the mouse button on one of them and dragging the mouse should select a range of them. to implement this i thought to use isItemActive and isItemHovered for these selectables. is that not possible? (it seems so)
in this case do i need to add invisible buttons over the selectables to make this work?
ty

Like this?

function MyScene:init()
	self.words = {
		{text = "dependent", selected = false},
		{text = "quizzical", selected = false},
		{text = "black", selected = false},
		{text = "substance", selected = false},
		{text = "bear", selected = false},
		{text = "side", selected = false},
		{text = "acrid", selected = false},
		{text = "moan", selected = false},
		{text = "notice", selected = false},
		{text = "alarm", selected = false},
		{text = "payment", selected = false},
		{text = "wind", selected = false},
	}
	self.selectMode = false
	self.selectorMinX = 0
	self.selectorMinY = 0
	self.selectorMaxX = 0
	self.selectorMaxY = 0
end
 
-- AABB intersection
function MyScene:itemSelected()
	local minX, minY = ui:getItemRectMin()
	local maxX, maxY = ui:getItemRectMax()
 
	return not (
			minX > self.selectorMaxX or 
			maxX < self.selectorMinX or 
			minY > self.selectorMaxY or
			maxY < self.selectorMinY)
end
 
function MyScene:draw()
	if ui:beginWindow("test") then 
		for i = 1, #self.words do 
			local item = self.words[i]
			ui:selectable(item.text, item.selected)
 
			-- a condition to turn on select mode
			if ui:isItemClicked(KeyCode.MOUSE_LEFT) then
				self.selectMode = true
			end
 
			if self.selectMode then
				item.selected = self:itemSelected()
			end
		end
 
		-- draw select rectangle
		if self.selectMode then 
			if ui:isMouseReleased(KeyCode.MOUSE_LEFT) then
				self.selectMode = false
			end
 
			if ui:isMouseDragging(KeyCode.MOUSE_LEFT) then 
 
				local list = ui:getWindowDrawList(true)
				local mx, my = ui:getMousePos()
				local dx, dy = ui:getMouseDragDelta(KeyCode.MOUSE_LEFT)
				local selectionMinX = mx - dx
				local selectionMinY = my - dy
 
				self.selectorMinX = selectionMinX >< mx
				self.selectorMinY = selectionMinY >< my
				self.selectorMaxX = mx <> selectionMinX
				self.selectorMaxY = my <> selectionMinY
 
				list:addRectFilled(selectionMinX, selectionMinY, mx, my, 0xffffff, 0.2)
			end
		end
	end
	ui:endWindow()
end

rrraptor · August 8

Still playing around with nodes

Trying to use different programming patterns. Commands, observers, strategy, builder, facade. Also tried ECS, but struggling with understanding how to use it xD

keszegh · August 8

rrraptor said:

Like this?

thanks @rrraptor , something like that, from this code i shall be able to make it the way i planned. i will try to share the outcome when it's done.

Howdy, Stranger!

Categories

In this Discussion

Top Posters

ImGui new thread

Comments

Howdy, Stranger!

Quick Links

Categories

In this Discussion

Top Posters

ImGui new thread

Comments