Feature parity for win32 version

keszegh

keszegh said:

i think the only thing i miss from win32 is the openhand cursor, are you realy sure it cannot be added?
https://learn.microsoft.com/en-us/windows/win32/uxguide/inter-mouse
in this page it is in the same slot as the 4-way arrow, which is included, so i guessed that perhaps openhand can be added too?

on the link i refer to the second icon in the "Compound mouse interactions" section, called 'pan' there.

hgy29

Really ? I mapped the OCR_ constants defined here: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setsystemcursor to those defined by QT, that way:https://github.com/gideros/gideros/blob/master/libgid/src/win32/platform-win32.cpp#L269

MoKaLux

one more thing please, now that we have win32 64 bits !!! what is it actually?

Imho win32 export doesn't sound good for promoting Gideros, what could we call win32 export? Windows without Qt? Windows64? ...

keszegh

@hgy29 there is some issue with screen, i open one and it is immediately fullscreen even though i call
s:setSize(800,480)
self.screen:setState(Screen.STATE_NORMAL)

keszegh

also application:set("cursor","cross") etc does not seem to work for me at all now for some reason.

MoKaLux

keszegh said:

also application:set("cursor","cross") etc does not seem to work for me at all now for some reason.

application:set("cursor", "cross") is working for me on win32 64 exported app

keszegh

MoKaLux said:

keszegh said:

also application:set("cursor","cross") etc does not seem to work for me at all now for some reason.

application:set("cursor", "cross") is working for me on win32 64 exported app

ok, more precisely:
1. it updates only if i move the mouse a bit.
2. it does not update at all if i'm using a pen (to press a button which would trigger a change in the cursor).

MoKaLux

keszegh said:

@hgy29 there is some issue with screen, i open one and it is immediately fullscreen even though i call
s:setSize(800,480)
self.screen:setState(Screen.STATE_NORMAL)

I have the correct? behavior when doing this:

local sss = Sprite.new() local img = Bitmap.new(Texture.new("gfx/ui/rpgpp_lt_models_vgood.png")) local ss = Screen.new(0) sss:addChild(img) ss:setPosition(128, 128) ss:setSize(128, 128) -- ss:setState(Screen.STATE_ACTIVE|Screen.STATE_MAXIMIZED|Screen.STATE_FULLSCREEN) ss:setTitle("test") print("ss", ss:getState()) ss:setContent(sss)

one issue though is when you resize the Screen it goes blank!

(the Screen is the one at the left of the player, 128*128px)

keszegh

try going full-screen with setState and then back? perhaps that's when it got stuck for me (even after restart).

MoKaLux

keszegh said:

try going full-screen with setState and then back? perhaps that's when it got stuck for me (even after restart).

MoKaLux said:

one issue though is when you resize the Screen it goes blank!

Yes can confirm that when going full screen (maximized) and then back the screen is blank for me.
One more thing about adding Screen states, when I do this

ss:setState(0+8) -- ss:setState(Screen.STATE_NORMAL + Screen.STATE_ACTIVE) print("ss", ss:getState()) --> 48!

I though that these would be the values but I may be wrong (taken from c++):
Screen.STATE_NORMAL 0
Screen.STATE_MINIMIZED 1
Screen.STATE_MAXIMIZED 2
Screen.STATE_FULLSCREEN 4
Screen.STATE_ACTIVE 8
Screen.STATE_HIDDEN 16
Screen.STATE_CLOSED 32

Plus also a bug? when you close the Screen the app closes too!

Plus a question: how do you set states? Like this ss:setState(Screen.STATE_NORMAL | Screen.STATE_ACTIVE) or like this ss:setState(Screen.STATE_NORMAL + Screen.STATE_ACTIVE)

MoKaLux

moved to https://forum.gideros.rocks/discussion/comment/68302/#Comment_68302

MoKaLux

It seems Event.KEY_DOWN and Event.KEY_UP don't behave the same on win32 and Qt/html5/android

In my game I implemented a jump input buffer (http://kpulv.com/106/Jump_Input_Buffering/) which works very well on all platforms but win32
html5 demo https://mokatunprod.itch.io/gideros-tests?secret=ht8e7uTPJgGUApRozoooCCEE

It seems win32 doesn't release the key (deleteKeyEvent) on Event.KEY_UP?

I had a look at the source code and found this extra code which isn't present in Qt, winRT, ...:

if (keyCode == 0) return;

https://github.com/gideros/gideros/blob/2f3e098af176a6d3c9461464bcb6d88871b482d7/libgid/src/win32/ginput-win32.cpp#L548

Could you confirm that this could be the issue please

I am on my way on testing on my side by building gideros BUILT AND TESTED DONE, ISSUE NOT FIXED

Thank you

EDIT: I built Gideros with my modifications (that is only commenting the above quoted code) but unfortunately that doesn't solve the issue
EDIT2: the issue happens when you quickly press and release (in my case the up arrow key) multiple times (it seems Gideros doesn't register the key up event?)
EDIT3: I attach a stripped project file if you want to compile for win32 and see the issue

MoKaLux

EDIT4: the "faulty" code is in Files/systems/splayer1 line 155 and 178

hgy29

I can't reproduce the issue, or I don't know what to look for. I always get a KEY_UP when I release a key, although on windows there is an autorepeat feture that causes multiple KEY_DOWN to be sent for a single key if you press the key more than half a second or so.

I will disable auto repeat stuff , since Gideros doesn't expect it.

MoKaLux

...although on windows there is an autorepeat feture that causes multiple KEY_DOWN to be sent for a single key if you press the key more than half a second or so.

I will disable auto repeat stuff , since Gideros doesn't expect it.

that was it, thank you captain